Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhysicalConsole: Fix UTF-8 related failure #1879

Closed
wants to merge 2 commits into from
Closed

PhysicalConsole: Fix UTF-8 related failure #1879

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ea6953
PhysicalConsole.check_status(): Use log.exception
zmc Aug 2, 2023
1964350
PhysicalConsole: Tolerate invalid UTF-8 characters
zmc Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions teuthology/orchestra/console.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ def _pexpect_spawn(self, cmd):
p = pexpect.spawn(
cmd,
encoding='utf-8',
codec_errors="backslashreplace",
)
p.logfile_read = io.StringIO()
return p
Expand Down Expand Up @@ -196,8 +197,8 @@ def check_status(self, timeout=None):
# check for login prompt at console
self._wait_for_login(timeout)
return True
except Exception as e:
self.log.info('Failed to get ipmi console status: {e}'.format(e=e))
except Exception:
self.log.exception('Failed to get ipmi console status')
return False

def power_cycle(self, timeout=300):
Expand Down
Loading