Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin PyYAML to fix CI breakage #1870

Merged
merged 2 commits into from
Jul 22, 2023
Merged

Pin PyYAML to fix CI breakage #1870

merged 2 commits into from
Jul 22, 2023

Conversation

zmc
Copy link
Member

@zmc zmc commented Jul 21, 2023

No description provided.

@zmc
Exclude PyYAML 5.4.0,5.4.1
2415065 
See yaml/pyyaml#601

Signed-off-by: Zack Cerza <zack@redhat.com>
@zmc zmc requested a review from dmick July 21, 2023 19:54
@zmc
Update pip-tools
c205639 
Signed-off-by: Zack Cerza <zack@redhat.com>
@zmc
Copy link
Member Author

zmc commented Jul 21, 2023 •
edited
Loading

The "dependencies" check is failing in the "Initial bootstrap" phase, which is simply reproducing the problem we're fixing here (it bootstraps from main first). The "CI" and "integration" checks are what matter here.

@zmc zmc mentioned this pull request Jul 21, 2023
Merged
dmick
dmick approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@dmick dmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lost in a sea of pinned versions because no one can keep backward compatibility, forced into creating technical debt for when the ancient pins finally break. Business as usual.

@dmick
Copy link
Member

dmick commented Jul 21, 2023

(obviously it'd be good if the checks passed.)

@dmick dmick merged commit ca7348b into main Jul 22, 2023
5 of 9 checks passed
@zmc zmc deleted the pyyaml-fix branch July 22, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmick dmick dmick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmc @dmick