Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ansible._handle_failure: Catch all Exceptions #1865

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Ansible._handle_failure: Catch all Exceptions #1865

merged 1 commit into from
Jul 13, 2023

Conversation

zmc
Copy link
Member

@zmc zmc commented Jul 13, 2023

@zmc
Ansible._handle_failure: Catch all Exceptions
8cd332d 
Signed-off-by: Zack Cerza <zack@redhat.com>
@zmc zmc requested a review from dmick July 13, 2023 22:59
dmick
dmick approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@dmick dmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we come back to this and do better analysis; except Exception is too broad to leave, IMO

@dmick dmick merged commit aa6a80e into main Jul 13, 2023
9 checks passed
@zmc
Copy link
Member Author

zmc commented Jul 13, 2023

Yep. Just want to be able to capture the raw records to implement analysis for them.

@zmc zmc deleted the ansible-fail-tolerate-exceptions branch July 14, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmick dmick dmick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmc @dmick