misc._ssh_keyscan: Sort keys before returning any

ssh-keyscan's output is unsorted, so this function wasn't deterministic. Signed-off-by: Zack Cerza <zack@redhat.com>
ceph · Sep 5, 2023 · dbd55e3 · dbd55e3
1 parent f9a8556
commit dbd55e3
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/teuthology/misc.py b/teuthology/misc.py
@@ -1138,9 +1138,11 @@ def _ssh_keyscan(hostname):
         line = line.strip()
         if line and not line.startswith('#'):
             log.error(line)
+    keys = list()
     for line in p.stdout:
         host, key = line.strip().decode().split(' ', 1)
-        return key
+        keys.append(key)
+    return sorted(keys)[0]
 
 
 def ssh_keyscan_wait(hostname):