Storage pool error check #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this looks good. Have you run it through any cluster creation tests yet? |
|
I just built a cluster using CBT and this PR, but I ran into some problems having nothing to do with my change, I think. I'll post those as separate issues or PRs but I did get it to run yesterday with this PR and build the cluster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tightens up the error checking from the previous PR #107, which had left pdsh commands unchecked by default. These checks allow CBT test to abort if early setup stage of test fails, otherwise you can be waiting for a long time to find out that your test did nothing. They should benefit any of the benchmarks that create storage pools. The checks are all in mkpool(), which creates the storage pool, and rmpool(), which removes a storage pool. BTW if a pool doesn't exist then ceph osd pool rm command will not return a failure status, so removal is idempotent.
Because of the first commit, I discovered a bug that is fixed in the 2nd commit.