Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing msg in ccb core #41

Merged
merged 10 commits into from
Jul 6, 2020
Merged

Replacing msg in ccb core #41

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b027bf3
enh(ccb_core) : replacing msg by msg_fmt
jbrouze Jun 25, 2020
6552894
enh(ccb_core) : replacing msg by msg_fmt
jbrouze Jun 26, 2020
d7b345a
enh(ccb_core) : replacing msg by msg_fmt
jbrouze Jun 26, 2020
0971c41
enh(ccb_core) : replacing msg by msg_fmt
jbrouze Jun 29, 2020
09b54d0
enh(ccb_core) : replacing msg by msg_fmt
jbrouze Jun 30, 2020
5228fe6
enh(ccb_core) : replacing msg by msg_fmt
jbrouze Jun 30, 2020
25f760b
enh(ccb_core) : requested changes
jbrouze Jul 1, 2020
0a281aa
enh(ccb_core) : requested changes
jbrouze Jul 6, 2020
abc79f4
Merge branch 'master' into replacing-msg-in-ccb_core
jbrouze Jul 6, 2020
3b4ed50
enh(ccb_core) : requested changes
jbrouze Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ccb_core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,5 +114,5 @@ set_target_properties(ccb_core PROPERTIES LINKER_LANGUAGE CXX)
set_target_properties(ccb_core PROPERTIES COMPILE_FLAGS "${MYSQL_CFLAGS} -fPIC")

target_link_libraries(ccb_core PUBLIC
CONAN_PKG::json11 CONAN_PKG::fmt CONAN_PKG::spdlog CONAN_PKG::zlib CONAN_PKG::asio ${MYSQL_LIBS}
CONAN_PKG::json11 CONAN_PKG::spdlog CONAN_PKG::zlib CONAN_PKG::asio ${MYSQL_LIBS}
)
4 changes: 2 additions & 2 deletions src/ccb_core/bbdo/input.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,12 +132,12 @@ static uint32_t set_string(io::data& t,
uint32_t len(strlen(str));
if (len >= size) {
log_v2::bbdo()->error(
"BBDO: cannot extract string value: no terminating '\\0' in remaining "
"BBDO: cannot extract string value: no terminating '\0' in remaining "
Copy link
Collaborator

@bouda1 bouda1 Jul 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted you to make the reverse: keep '\\0' and not '\0'

"{} bytes left in packet",
size);

throw msg_fmt(
"BBDO: cannot extract string value: no terminating '\\0' in remaining "
"BBDO: cannot extract string value: no terminating '\0' in remaining "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem

"{} bytes of packet",
size);
}
Expand Down