Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "updated file rights in centreon-broker & centreon-engine (#12… #1287

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

tuntoja
Copy link
Contributor

@tuntoja tuntoja commented Apr 19, 2024

…67)"

This reverts commit 1649951.

Description

Fixes #MON-56532

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x
  • master

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Summary by CodeRabbit

  • Changes
    • Updated file permissions for several configuration files in Centreon Broker and Centreon Engine to allow more permissive access.

@tuntoja tuntoja requested a review from a team as a code owner April 19, 2024 12:25
Copy link
Contributor

coderabbitai bot commented Apr 19, 2024

Walkthrough

The recent updates across different Centreon packaging configurations involve a uniform change in file permissions. Specifically, the permissions for several configuration files have been altered from 0660 to 0664, allowing for slightly more permissive read access.

Changes

File Path Change Summary
.../centreon-broker-cbd.yaml Updated file permissions from 0660 to 0664 for several configuration files.
.../centreon-broker-cbmod.yaml Modified file permissions for central-module.json from 0660 to 0664.
.../centreon-engine-daemon.yaml Updated file permissions from 0660 to 0664 for configuration files (centengine.cfg, resource.cfg, commands.cfg, timeperiods.cfg).

🐇✨
In the land of code and gears,
A small change brings big cheers.
Files once snug, now slightly free,
Permissions changed, from me to thee.
Hop and tweak, adjust the byte,
In Centreon's realm, we code by twilight.
🌟📂


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 3741a70 and e6bcdbe.
Files selected for processing (3)
  • packaging/centreon-broker-cbd.yaml (1 hunks)
  • packaging/centreon-broker-cbmod.yaml (1 hunks)
  • packaging/centreon-engine-daemon.yaml (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 8

packaging/centreon-broker-cbmod.yaml Show resolved Hide resolved
packaging/centreon-broker-cbd.yaml Show resolved Hide resolved
packaging/centreon-broker-cbd.yaml Show resolved Hide resolved
packaging/centreon-broker-cbd.yaml Show resolved Hide resolved
packaging/centreon-engine-daemon.yaml Show resolved Hide resolved
packaging/centreon-engine-daemon.yaml Show resolved Hide resolved
packaging/centreon-engine-daemon.yaml Show resolved Hide resolved
packaging/centreon-engine-daemon.yaml Show resolved Hide resolved
@tuntoja tuntoja merged commit 18e6b8e into develop Apr 19, 2024
15 checks passed
@tuntoja tuntoja deleted the MON-56532-revert-mon-6832 branch April 19, 2024 14:24
tuntoja added a commit that referenced this pull request Apr 19, 2024
tuntoja added a commit that referenced this pull request Apr 19, 2024
tuntoja added a commit that referenced this pull request Apr 22, 2024
tuntoja added a commit that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants