Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mon 34326 allow to extend engine configuration with a custom file #1231

Conversation

jean-christophe81
Copy link
Contributor

@jean-christophe81 jean-christophe81 commented Mar 28, 2024

REFS:MON-34326

Description

centengine accepts --config-file command line argument to pass a custom json config file

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Copy link
Contributor

coderabbitai bot commented Mar 28, 2024

Important

Auto Review Skipped

Auto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jean-christophe81 jean-christophe81 force-pushed the MON-34326-Allow-to-extend-Engine-configuration-with-a-custom-file branch 2 times, most recently from a7f8787 to 7aab4f4 Compare April 2, 2024 07:41
@jean-christophe81 jean-christophe81 marked this pull request as ready for review April 2, 2024 14:57
@jean-christophe81 jean-christophe81 requested review from a team as code owners April 2, 2024 14:57
broker/neb/src/broker.cc Outdated Show resolved Hide resolved
common/CMakeLists.txt Show resolved Hide resolved
common/inc/com/centreon/common/rapidjson_helper.hh Outdated Show resolved Hide resolved
common/src/rapidjson_helper.cc Outdated Show resolved Hide resolved
common/src/rapidjson_helper.cc Show resolved Hide resolved
engine/src/main.cc Outdated Show resolved Hide resolved
engine/src/main.cc Outdated Show resolved Hide resolved
tests/broker-engine/notification.robot Outdated Show resolved Hide resolved
tests/broker-engine/notification.robot Outdated Show resolved Hide resolved
tests/broker-engine/notification.robot Outdated Show resolved Hide resolved
@jean-christophe81 jean-christophe81 force-pushed the MON-34326-Allow-to-extend-Engine-configuration-with-a-custom-file branch from 9980634 to 764edbb Compare May 13, 2024 10:49
@jean-christophe81 jean-christophe81 force-pushed the MON-34326-Allow-to-extend-Engine-configuration-with-a-custom-file branch from 764edbb to d77a58b Compare May 13, 2024 12:16
@bouda1 bouda1 merged commit 15fc46f into develop May 14, 2024
31 checks passed
@bouda1 bouda1 deleted the MON-34326-Allow-to-extend-Engine-configuration-with-a-custom-file branch May 14, 2024 07:48
kduret pushed a commit that referenced this pull request Jun 24, 2024
kduret pushed a commit that referenced this pull request Jul 10, 2024
kduret pushed a commit that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants