Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(webpack): Adapt font regexp path for Windows #8375

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

Thebarda
Copy link
Contributor

Pull Request Template

Description

This PR fixes Regexp path about fonts for windows

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 2.8.x
  • 18.10.x
  • 19.04.x
  • 19.10.x
  • 20.04.x (master)

How this pull request can be tested ?

Front builds should pass.

Checklist

Community contributors & Centreon team

  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Centreon team only

  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests cover 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@@ -28,7 +28,7 @@ module.exports = merge(baseConfig, extractCssConfig, {
rules: [
{ parser: { system: false } },
{
test: /fonts\/.+\.(woff(2)?|ttf|eot|svg)(\?v=\d+\.\d+\.\d+)?$/,
test: /fonts(\\|\/).+\.(woff(2)?|ttf|eot|svg)(\?v=\d+\.\d+\.\d+)?$/,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think cross-env could solve also this issue

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tried without success :'(

@Thebarda Thebarda merged commit 80add3b into master Feb 28, 2020
@Thebarda Thebarda deleted the MON-4941-adapt-regexp-path branch February 28, 2020 10:24
victorvassilev added a commit that referenced this pull request Mar 6, 2020
* Adapt font regexp path for Windows (#8375)

* enh(apiv2): add event listing for hosts and services
Resolves: MON-4866, MON-4867

* enh(apiv2): add event listing for hosts and services
Resolves: MON-4866, MON-4867

* fix(doc): regenerate html for doc

* feat(ui): Implement Resources listing (#8371)

* fix(tests): update error message on unit test

* Fix the search parameter 'IN' (#8380)

* fix(doc): fix scrollbar issue in API documentation (#8378)

* feat(build): stash git sources for Sonar analysis.

* feat(ui): Implement Unified view search (#8382)

* feat(build): fail build on front-end style errors.

* enh(doc): update docblock in interface

* fix: fix ESLint warnings

* doc(api): document how to use search parameter with API (#8376)

* fix(test): improve unit test SqlRequestParametersTranslatorTest::testTranslateSortParameterToSql

* fix(configuration): export hosts geo_coords to remote server (#8390)

* fix(ldap): use define user member_attribute var (#8287)

* fix(ldap): use define user member_attribute var

* fix(code): use PSR2

* feat(ui): Implement Unified view downtime and acknowledge tooltips (#8385)

* fix(code): Clean switch case service monitoring (#8285)

* fix(code): dedicated meta event console does not exist anymore

* fix(code): scheduling queue console does not exist anymore

* fix(code): merge some cases

Co-authored-by: Colin Gagnaire <cgagnaire@centreon.com>

* fix(remote-server): fix import with strict mode (#7944)

Refs: MON-7944

* doc(api): document how to generate html api documentation (#8394)

* feat(doc): update the API documentation (#8393)

* feat(doc): update the API documentation

Resolve MON-4887

* fix(doc): apply feedback from PR

Resolve MON-4887

* fix(doc): remove again api html documentation

* Update src/Centreon/Domain/Monitoring/Entity/DowntimeEventObject.php

Co-Authored-By: Kevin Duret <kduret@centreon.com>

* Update src/Centreon/Domain/Monitoring/Interfaces/TimelineRepositoryInterface.php

Co-Authored-By: Kevin Duret <kduret@centreon.com>

* Update src/Centreon/Domain/Monitoring/Interfaces/EventObjectInterface.php

Co-Authored-By: Kevin Duret <kduret@centreon.com>

* Update package-lock

* enh(apiv2): add event listing for hosts and services
Resolves: MON-4866, MON-4867

* fix(doc): regenerate html for doc

* fix(tests): update error message on unit test

* enh(doc): update docblock in interface

* Update src/Centreon/Domain/Monitoring/Entity/DowntimeEventObject.php

Co-Authored-By: Kevin Duret <kduret@centreon.com>

* Update src/Centreon/Domain/Monitoring/Interfaces/TimelineRepositoryInterface.php

Co-Authored-By: Kevin Duret <kduret@centreon.com>

* Update src/Centreon/Domain/Monitoring/Interfaces/EventObjectInterface.php

Co-Authored-By: Kevin Duret <kduret@centreon.com>

* resolve conflict with html doc

Co-authored-by: Tom Darneix <tomdar87@outlook.com>
Co-authored-by: Bruno d'Auria <bdauria@centreon.com>
Co-authored-by: Laurent Calvet <lcalvet@centreon.com>
Co-authored-by: Kevin Duret <kduret@centreon.com>
Co-authored-by: Matthieu Kermagoret <mkermagoret@centreon.com>
Co-authored-by: Valentin Hristov <vhr@users.noreply.github.com>
Co-authored-by: Colin Gagnaire <cgagnaire@centreon.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants