Celo Dynamic Fee V2

[gastonponti]

Description

Celo dynamic fee v2 implements the CIP (celo-org/celo-proposals#393)

Backwards compatibility

Part of the Gingerbread Hard Fork

[github-actions]

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit b7893f5

coverage: 50.4% of statements across all listed packages

coverage:  62.8% of statements in consensus/istanbul
coverage:  42.7% of statements in consensus/istanbul/announce
coverage:  55.7% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  63.9% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random

[github-actions]

Test failures:
TestEthersJSCompatibility: e2e_test Checking getExchangeSpenders. spenders = [0x000000000000000000000000000000000000d028] Checking medianRate. numerator = 1000000000000000000000000 denominator = 1000000000000000000000000 Checking gas price minimum. cusdValue = 100000000 executing mocha test with /usr/bin/npm run --networkaddr=http://127.0.0.1:35573 test --blocknum=0x0 -- --grep ethers.js compatibility tests with state ethersjs-api-check@1.0.0 test /runner/_work/celo-blockchain/celo-blockchain/e2e_test/ethersjs-api-check mocha -r ts-node/register test/*.ts "--grep" "ethers.js compatibility tests with state" ethers.js compatibility tests with state ✔ provider.getBlock works (block has gasLimit set) (50ms) ✔ EIP-1559 transactions supported (can get feeData) ✔ block has gasLimit 1) block has baseFeePerGas 3 passing (117ms) 1 failing ethers.js compatibility tests with state block has baseFeePerGas: AssertionError: expected false to be true expected - actual -false +true at /runner/_work/celo-blockchain/celo-blockchain/e2e_test/ethersjs-api-check/test/test.ts:52:10 at Generator.next () at fulfilled (test/test.ts:5:58) at processTicksAndRejections (internal/process/task_queues.js:95:5) npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! ethersjs-api-check@1.0.0 test: mocha -r ts-node/register test/*.ts "--grep" "ethers.js compatibility tests with state" npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the ethersjs-api-check@1.0.0 test script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above. npm ERR! A complete log of this run can be found in: npm ERR! /home/runner/.npm/_logs/2023-08-17T19_03_18_974Z-debug.log e2e_test.go:685: </code></pre></td></tr>
This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.

[codecov]

Codecov Report

Patch coverage: 20.86% and project coverage change: +0.08% 🎉

Comparison is base (0404e7a) 55.15% compared to head (3a0f1c1) 55.24%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2170      +/-   ##
==========================================
+ Coverage   55.15%   55.24%   +0.08%     
==========================================
  Files         676      677       +1     
  Lines      114015   114252     +237     
==========================================
+ Hits        62887    63114     +227     
- Misses      47248    47274      +26     
+ Partials     3880     3864      -16     

Files Changed	Coverage Δ
common/types.go	58.52% <0.00%> (-0.55%)	⬇️
core/state_processor.go	81.34% <0.00%> (-1.87%)	⬇️
core/types/celo_dynamic_fee_tx.go	1.53% <0.00%> (ø)
internal/ethapi/transaction_args.go	0.00% <0.00%> (ø)
light/txpool.go	39.34% <0.00%> (-2.04%)	⬇️
core/types/celo_dynamic_fee_tx_v2.go	1.66% <1.66%> (ø)
core/types/transaction_marshalling.go	23.90% <2.70%> (-5.70%)	⬇️
core/types/receipt.go	34.76% <25.00%> (-0.46%)	⬇️
core/types/transaction_signing.go	57.73% <36.53%> (-4.83%)	⬇️
internal/ethapi/api.go	4.31% <41.17%> (+0.42%)	⬆️
... and 8 more

... and 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.