Solve Kombu filesystem transport not thread safe #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://github.com/avatars/in/57789?s=60&v=4){kind=small}
fix: celery#398 Currently only write lock used in msg/exchange file written. Cause reading in other thread got some incomplete result. 1. Add timeout for the lock acquire. 2. Add Share locks when reading message from filesystem. 3. Add a unit test for the `lock` and `unlock` 4. Add a unit test to test the lock during message processing.
|
This pull request fixes 1 alert when merging 4b7e67d into ec533af - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 8e66845 into ec533af - view on LGTM.com fixed alerts:
|
auvipy
approved these changes
Sep 7, 2022
karajan1001
added a commit
to karajan1001/kombu
that referenced
this pull request
Sep 9, 2022
This reverts commit 8699920.
auvipy
pushed a commit
that referenced
this pull request
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #398
Currently only write lock used in msg/exchange file written. Cause
reading in other thread got some incomplete result.
lockandunlock