Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

change "go back" button's height to the same height as "cancel report" button #1666

Merged
merged 3 commits into from
Mar 16, 2020

Conversation

DianeLiu2019
Copy link
Contributor

Fixes #1650 (issue)

change "go back" button's height to the same height as "cancel report"… button on confirmCancel page

Checklist:

  • [ x] I have looked at my code on GitHub and it all looks good (ex: no random commented out code or console.logs)

@sastels sastels temporarily deployed to rac-prototyp-backbutton-pxa0jb March 12, 2020 15:35 Inactive
Copy link
Contributor

@amazingphilippe amazingphilippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -44,6 +44,7 @@ export const ConfirmCancelPage = () => {
onClick={() => history.goBack()}
fontSize={{ base: 'lg', md: 'xl' }}
color="black"
height="3rem"
variant="link"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also remove this line!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted the unneeded line

@sastels sastels temporarily deployed to rac-prototyp-backbutton-pxa0jb March 16, 2020 14:37 Inactive
@DianeLiu2019 DianeLiu2019 merged commit 487c11d into master Mar 16, 2020
@DianeLiu2019 DianeLiu2019 deleted the BackButtonCancelPage branch March 16, 2020 14:39
sastels added a commit that referenced this pull request Mar 19, 2020
* Minor copy change (typo) (#1639)

* extract data from formidable manually (#1641)

* fix: upgrade mongodb from 3.5.2 to 3.5.3 (#1632)

* fix: upgrade react-scripts from 3.3.1 to 3.4.0 (#1642)

* Fix for Logs in another Azure Subscription (#1619)

* Updating IMAGE_NAME reference (#1597)

* change GNCC to GNC3 (#1655)

* use redirect for equifax links (#1651)

* clear file input after alert (#1662)

* fix keyboard nav (#1660)

* add moneyLost.methodOther field to analyst report (#1647)

* more detailed p and text stories (#1643)

* added stuff to sb docs (#1671)

* added getting started page to storybook (#1661)

* FIX CORS for HTTPS (#1665) (#1669)

* clean up logging a bit (#1663)

* tweak skiplink style (#1658)

* fix target area for upload button (#1653)

* change "go back" button's height to the same height as "cancel report" button (#1666)

* added Messages component.  (#1644)

* fix: upgrade async from 3.1.1 to 3.2.0 (#1680)

* Reports a day counter (#1664)

* Form validation - bump (#1510)

* added helmet in server.js (#1674)

* Combine analyst emails (#1628)

* Prod version number (#1656)

* Fixed Field, added container and layout to sb (#1675)

* Get email addresses from ldap query (#1682)

* restrict file number and size on server (#1648)

* remove submit button if already submitted (#1683)

* Fix for Continuous Deployment (#1690)

* Validation for location fields (#1689)

* cypress pack initial commit (#1247)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go back button on cancel page is squished on mobile devices
3 participants