Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for i18n to initialize #149

Merged
merged 2 commits into from
May 4, 2021
Merged

Wait for i18n to initialize #149

merged 2 commits into from
May 4, 2021

Conversation

bryan-robitaille
Copy link
Contributor

Summary | Résumé

This PR implements a fix that is caused by the next-i18next package that leverages react-i18next under the hood. It tries to use Suspense however given that some of the pages are rendered server side the Suspense function doesn't exist.

Solution posted here on NextJS github repo

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2021

Jest Coverage

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 88.34 70.98 92.39 88.41
File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 88.34 70.98 92.39 88.41
_components/forms/Alert 100 87.5 100 100
_ Alert.tsx 100 87.5 100 100 41
_components/forms/Button 100 100 100 100
_ Button.tsx 100 100 100 100
_components/forms/Checkbox 100 50 100 100
_ Checkbox.tsx 100 50 100 100 26
_components/forms/Description 100 100 100 100
_ Description.tsx 100 100 100 100
_components/forms/Dropdown 100 70 100 100
_ Dropdown.tsx 100 70 100 100 32,42
_components/forms/DynamicRow 100 75 100 100
_ DynamicRow.tsx 100 75 100 100 56
_components/forms/ErrorMessage 100 100 100 100
_ ErrorMessage.tsx 100 100 100 100
_components/forms/FileInput 54.17 16.67 60 56.52
_ FileInput.tsx 54.17 16.67 60 56.52 29-39
_components/forms/Form 85.71 50 100 85.71
_ Form.tsx 85.71 50 100 85.71 29,32,96
_components/forms/FormGroup 100 100 100 100
_ FormGroup.tsx 100 100 100 100
_components/forms/Heading 100 100 100 100
_ Heading.tsx 100 100 100 100
_components/forms/Label 100 83.33 100 100
_ Label.tsx 100 83.33 100 100 34
_components/forms/Radio 100 50 100 100
_ Radio.tsx 100 50 100 100 23
_components/forms/RichText 100 100 100 100
_ RichText.tsx 100 100 100 100
_components/forms/TextArea 100 50 100 100
_ TextArea.tsx 100 50 100 100 27
_components/forms/TextInput 100 50 100 100
_ TextInput.tsx 100 50 100 100 30-37
_lib 87.78 75.96 91.8 87.55
_ dataLayer.tsx 93.69 79.69 96.3 93.58 71,74,121-122,220-226
_ formBuilder.tsx 86.59 81.01 100 86.42 35,44-45,81-87,200,216,236,271
_ logger.tsx 73.33 87.5 75 71.43 10-15
_ markdown.tsx 100 100 100 100
_ routeUtils.tsx 100 60 100 100 7-19
_ validation.tsx 74.42 63.83 62.5 73.81 69-74,133,152-155
Done in 11.24s.

Copy link
Contributor

@fitore-cds fitore-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn. Thanks for this one!

@bryan-robitaille bryan-robitaille temporarily deployed to platform-for-i18n-bug-f-3dlxym May 4, 2021 19:33 Inactive
@bryan-robitaille bryan-robitaille merged commit 5d21dd1 into main May 4, 2021
@bryan-robitaille bryan-robitaille deleted the i18n-bug-fix branch May 4, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants