Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate from k8s.gcr.io to registry.k8s.io #1172

Closed
wants to merge 2 commits into from
Closed

chore: migrate from k8s.gcr.io to registry.k8s.io #1172

wants to merge 2 commits into from

Conversation

ahmedwaleedmalik
Copy link

Kubernetes is migrating its image registry from k8s.gcr.io to registry.k8s.io.

Part of kubernetes/k8s.io#4780.

@ahmedwaleedmalik
Copy link
Author

@mrgrain can you PTAL?

Copy link
Contributor

@vinayak-kukreja vinayak-kukreja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you for your contribution. Just a minor comment.

test/fixtures/guestbook-all-in-one.yaml Outdated Show resolved Hide resolved
@vinayak-kukreja
Copy link
Contributor

Looks like build is failing for mutation since this was originated from a fork. Could you update your branch?

Run echo "::error::Files were changed during build (see build log). If this was triggered from a fork, you will need to update your branch."
  echo "::error::Files were changed during build (see build log). If this was triggered from a fork, you will need to update your branch."
  cat .repo.patch
  exit 1
  shell: /usr/bin/bash -e {0}
  env:
    CI: true
Error: Files were changed during build (see build log). If this was triggered from a fork, you will need to update your branch.
diff --git a/test/__snapshots__/yaml.test.ts.snap b/test/__snapshots__/yaml.test.ts.snap
index dd2e186..f6c89c0 100644
--- a/test/__snapshots__/yaml.test.ts.snap
+++ b/test/__snapshots__/yaml.test.ts.snap
@@ -87,7 +87,7 @@ Array [
         "spec": Object {
           "containers": Array [
             Object {
-              "image": "registry.k8s.io/redis:e2e",
+              "image": "k8s.gcr.io/redis:e2e",
               "name": "master",
               "ports": Array [
                 Object {
Error: Process completed with exit code 1.

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@vinayak-kukreja
Copy link
Contributor

Hey, @ahmedwaleedmalik, our build step cannot run on a fork. Could you run yarn build on your fork and update here.

@ahmedwaleedmalik
Copy link
Author

Hey, @ahmedwaleedmalik, our build step cannot run on a fork. Could you run yarn build on your fork and update here.

Not sure what you want from me here? Do you want me to build it and check if it's working? Then yes, i was able to build it.

@vinayak-kukreja
Copy link
Contributor

Hey @ahmedwaleedmalik, we have taken care of this issue and would be closing this PR now.

We thank you for your contribution and bringing visibility into this. Really appreciate it. :)

@ahmedwaleedmalik
Copy link
Author

Hey @ahmedwaleedmalik, we have taken care of this issue and would be closing this PR now.

We thank you for your contribution and bringing visibility into this. Really appreciate it. :)

So the maintainers didn't bother to reply for a month and then just closed the PR. Seems like you folks are very "open source" friendly.

@ahmedwaleedmalik ahmedwaleedmalik deleted the update-k8s-registry branch May 17, 2023 07:30
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants