Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xfel striping fix #844

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Xfel striping fix #844

wants to merge 11 commits into from

Conversation

Baharis
Copy link
Contributor

@Baharis Baharis commented Jan 28, 2023

Introduce some changes to striping to improve current behavior. In particular, currently cctbx.xfel.stripe_experiment stripes/chunks expt and refl files instead of actual experiments and reflections. However, since I have prepared the implementation in hurry, "striping" does not stripe anymore, but rather distributes randomly. Also, some improvements to the default parameters have been suggested.

@Baharis
Copy link
Contributor Author

Baharis commented Jan 28, 2023

Disclaimer: I might be unable to find time in the nearest future to fully fix the striping (i.e. read data and stripe it instead of files), but I believe some of the changes suggested here could be useful.

@Baharis Baharis self-assigned this Feb 1, 2023
@Baharis Baharis requested a review from phyy-nx February 1, 2023 22:38
@Baharis
Copy link
Contributor Author

Baharis commented Feb 1, 2023

For anyone wandering about implementing real striping experiment-wise: since the striping/chunking script accepts and returns expt/refl paths and not individual experiments + associated reflections, one cannot patch-in real experiment-wise striping without significantly changing the workflow of routines which use it to handle actual objects instead of paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant