Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bulk_solvent::k_mask_and_k_overall_grid_search #692

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bulk_solvent::k_mask_and_k_overall_grid_search #692

wants to merge 1 commit into from

Conversation

sizmailov
Copy link

Two rather small changes, probably it's fine to keep in one PR.

  • Add missing selection argument to scale()
  • Initialize k_overall_best / r_best to match k_mask_best = 0.0 case

Closes #654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Missing "selection" argument in bulk_solvent::k_mask_and_k_overall_grid_search
1 participant
@sizmailov