Fix compile on iOS #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI I used this with React Native 0.43.3 |
|
@benoist do you want to update the Readme too to provide notes on installing w/o CocoaPods? |
|
Well you still need cocoapods to install the twilio libraries in the main project. It's just that this library does not have any references to the twilio library, but expects the main project to have them included and uses the search locations to find the header files. |
|
Oh got it. That makes it much cleaner. I think you can manually download the SDKs, but that doesn't have to be in the scope of this push. |
despacito
approved these changes
May 12, 2017
despacito
approved these changes
May 12, 2017
mcatmos
approved these changes
May 12, 2017
bradbyte
approved these changes
May 12, 2017
bradbyte
approved these changes
May 12, 2017
This was referenced May 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed the references to the twilio pod files and fixed the projects search paths.
I also used the new React import style