TS updates

[thompsongl]

disabled is not available on a and label, but it looks like the styling is handled. I didn't visually test, though

[cchaos]

Ahhh... hmmm.

So I was hoping that EuiButtonDisplay would try to be as element agnostic as possible so that the consuming component, EuiButton, would be passing the appropriate combination of props, ie disabled to a <button>. Is it possible to move the logic you added primarily to EuiButton instead? That way then element could easily be changed to just string.

[thompsongl]

I can take another pass move the logic around.
But I think at some point there will have to be a check to see what kind of element element is so that the ref can be correctly cast.

[cchaos]

Yeah I think the ref is the main trouble spot too.

[thompsongl]

Yeah I think the ref is the main trouble spot too.

Looking again, if element needs to be even more generic, I'm not sure we can actually type it correctly and would // @ts-ignore the return. That's what happens inEuiFlexItem where we do the same kind of thing.

[thompsongl]

At some point ref does need to be cast, so the choices are either define a set of elements and use logic to pass the correct props, or allow any element and ignore the type check.

[cchaos]

Since EuiButtonDisplay is an internal component only, I'd say let's TS ignore the ref/return in THAT component, but then ensure that EuiButton is appropriately assigning props to HTML element

[cchaos]

Out of curiosity, what is this/does this mean?

[cchaos]

Also, would React.createElement help here in any way?

[thompsongl]

keyof JSX.IntrinsicElements

It will allow for basically any HTML element

Also, would React.createElement help here in any way?

That's an interesting idea. Let me try it out; I'm not actually sure what TS will do it.