Fix dangling reference warning on assign object property #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't change the behavior, it just silences this compiler warning when using FMDB in a project that has the -Wobjc-property-assign-on-object-type warning flag. https://clang.llvm.org/docs/AutomaticReferenceCounting.html#property-declarations The alternative would have been to make this a weak property, but this would have been a behavior change, and after reading the discussion ccgus#522, I gather that this is something that shouldn't be done in FMDB without bumping the major version number.
|
您的邮件已经收到，我会尽快查阅，谢谢！Best Wishes!
|
|
Thanks for doing this - it's merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change the behavior, it just makes the behavior explicit and silences this compiler warning when using FMDB in a project that has the
-Wobjc-property-assign-on-object-typewarning flag:The alternative would have been to make this a weak property, but this would have been a behavior change, and after reading the discussion #522, I gather that this is something that shouldn't be done in FMDB without bumping the major version number.