-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch source of IDs/adjectives for name generator to GitHub #26
Conversation
@@ -2,7 +2,7 @@ | |||
# R specific hooks: https://github.com/lorenzwalthert/precommit | |||
repos: | |||
- repo: https://github.com/lorenzwalthert/precommit | |||
rev: v0.3.2.9013 | |||
rev: v0.4.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally unrelated to this PR but for the fact that the check failed due to a super old version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Moving forward, am I right to assume that we'll reuse the implementation in ccao
in other projects? Or is each project going to reimplement this same read_csv
logic?
"https://github.com/raw/ccao-data/data-architecture/master/", | ||
"dbt/seeds/ccao/ccao.adjective.csv" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Thought, non-blocking] I think this is probably the best option, but it makes me a little bit nervous that the behavior of the name generator could change for a single installed version of the package. Not sure what to do about that, but I wanted to voice my uncertainty!
Well, the res and condo models will use the |
This PR is a quick follow-up to ccao-data/data-architecture#451. It updates the
ccao
package to point to the new GitHub tables as the source of names/adjectives for theccao_generate_id()
function.