Handle empty events array #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's common to pre-emptively call `off` with an event and handler prior to any handlers being registered. This is a safeguard to ensure that the same handler isn't attached multiple times. In this scenario, the events array isn't checked for existence prior to the accessor call (for the given selector). Thus a TypeError is raised. Closes ccampbell#31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common to pre-emptively call
offwith an event and handler priorto any handlers being registered. This is a safeguard to ensure that the
same handler isn't attached multiple times. In this scenario, the events
array isn't checked for existence prior to the accessor call (for the
given selector). Thus a TypeError is raised.
Closes #31