Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if window is defined before assigning to it #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Check if window is defined before assigning to it #27

wants to merge 2 commits into from

Conversation

codeclown
Copy link

#22

@ccampbell
Copy link
Owner

Curious what is the use case for Gator when there is no window?

@codeclown
Copy link
Author

I don't have a concrete use case to offer (maybe @rubennorte). However, not a good practice to bind to global window just assuming it's there.

@ccampbell
Copy link
Owner

Oh I missed the other ticket. So when using via dom in node there is no window. Got it

@adaniliuk
Copy link

@ccampbell would you mind to merge this fix?

@jasonkarns jasonkarns mentioned this pull request Dec 12, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codeclown @ccampbell @adaniliuk