Enable tests that are _still_ disabled #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veox
changed the title
|
Tests: https://circleci.com/gh/veox/py-evm/tree/investigate-create2-failures (Does this link work for anyone but me?..) |
|
The link works for me! |
|
I see at least one CI test job fails there - There are many more failing cases, not just |
veox
changed the title
|
Applying this PR increases the failure count from 10 (as in ethereum#1181 ATM) to 179 (in |
cburgdorf
force-pushed
the
christoph/tests/constantinople
branch
from
4f5a8ed
to
49934bf
Compare
pipermerriam
force-pushed
the
christoph/tests/constantinople
branch
from
49934bf
to
04ac2a5
Compare
2 COMMITS SQUASHED: fixtures: include missing Constantinople in helpers. Debugging CREATE2 using the full "Blockchain" tests in `fixtures` (they are disabled in `py-evm`, because they're slow and a duplication of "State" tests). A few definitions are missing - so add them. tests/conftest: fix VM-tracing log-to-file helper. Also move `import`s out of the helper, so they're not encountered by the interpreter on every invocation of the helper.
veox
force-pushed
the
investigate-create2-failures
branch
from
00377ed
to
d30382f
Compare
|
Rebased on underlying PR - which has itself been rebased on upstream |
One is existing `RevertInCreateInInit`, but now for Constantinople, not just Byzantium. The other is `RevertInCreateInInitCreate2`, which contains the same "synthhetic" state which can't be arrived at by regular means in the EVM. It's likely a copy-paste atavism.
veox
force-pushed
the
investigate-create2-failures
branch
from
d30382f
to
d2d119d
Compare
veox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
CREATE2was not actingCREATE-like.Also, some
Constantinopletests are still disabled.How was it fixed?
See explanation in ethereum#1181 (comment) or commit 00377ed.Essential commit also submitted toethereum/py-evmseparately, as ethereum#1560.Also, the other commits relevant to ethereum#1181 are included.
Cute Animal Picture
Source: Noah's Ark companion animal hospital in Franklin, NC