[pull] 24.11.00 from Aspen-Discovery:24.11.00 #963
+1,236
−359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://github.com/avatars/in/12910?s=60&v=4){kind=small}
Added cellphone field on patron profile page and Library Systems -> ILS Account Information -> User Profile -> Show Cellphone In Profile setting. Only applies to Symphony. Also updated description for Show Notice Type in Profile to indicate that it applies to Symphony.
Add cellphone field option to patron profile for Symphony
Fix pagination for materials request management page to allow viewing/exporting larger sets of data Fix issue where overdue Sierra ILL items that accrue fines no longer had an item ID and caused the following error: Sierra::getTitleByItemID(): Argument #2 ($itemShortID) must be of type string, null given Updated release notes
Small Bug Fixes
- Remove the 'message' variable that makes sense with the ILS-di mechanism, but not using the API
Delete a non-existent field in Koha API response
When an Aspen error is thrown for EBSCO EDS search and the searchError.tpl file is displayed, instead of the original error message, this php error is shown: Cannot use object of type AspenError as array Test plan: - navigate to Aspen Administration > EBSCO EDS > Settings - create a new Setting, make sure to use invalid credentials and save - navigate to Aspen Administration > Primary Configuration > Library Systems and select your current Library - set its EDS Setting to the setting you just created - run a search in Articles and Databases Before this commit: The error message is uninformative (Cannot use object of type AspenError as array). After this commit: The error message refers to a specific cause.
Test plan:
- navigate to Aspen Administration > EBSCO EDS >
Settings
- create a new Setting, make sure to use invalid
credentials and save
- navigate to Aspen Administration > Primary
Configuration > Library Systems and select your
current Library
- set its EDS Setting to the setting you just
created
- log out
- run a search in Articles and Databases
Before this commit:
An error message appears at the top of the screen.
This message contains the information sent back by
EDS.
After this commit:
The error message does not show on screen anymore
and is logged instead.
…rror 24.10.00 handle eds search error
Caused errors using the sendEmail method.
Comment out debugging code from SMTPSetting.php
Error messages should narrow down the cause to whether the pertain to authentication, issues loading data from EDS, or processing the search, and do so without risking to expose any data that should not be made publicly visible. Test plan: - navigate to Aspen Administration > EBSCO EDS > Settings - create a new Setting, make sure to use invalid credentials and save - navigate to Aspen Administration > Primary Configuration > Library Systems and select your current Library - set its EDS Setting to the setting you just created - log out - run a search in Articles and Databases Before this commit, the error message will indicate that the EDS search failed. After this, it will indicate that it failed due to an EDS authentication issue. Note: this also removes the possibility for errors thrown during the search processing to be show to the end user directly - they are logged instead.
…rror feat: error messages are specific
Correct so screen refreshes after selecting a hold candidate Do not show select hold candidate button if there is only one candidate Fix displaying pickup location for materials requests Fix to show the correct message when manually generating hold candidates Fix to show success message when placing holds
- When a user marks a field as unwanted in Koha, it should be hidden from patrons in Aspen when they are completing a Material request form, but it is displayed anyway. This patch fixes that error.
…/PTFS-Europe/aspen-discovery into PTFS-Europe-24.10.00_handle_eds_search_error
Also rebuild the default SQL file.
…form_unwanted_fields Issue 105308 suggestion form unwanted fields
Use natural sort for selecting items when placing a hold
Fix the following error: get_class(): Argument #1 ($object) must be of type object, bool given on line 561 of EbscoEdsSearcher.php
Update EbscoEdsSearcher.php
Fix the following error: get_class(): Argument #1 ($object) must be of type object, bool given on line 561 of EbscoEdsSearcher.php
Update EbscoEdsSearcher.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )