feat: support autoDetectColorScheme in icon sync
#399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
users can set their active color theme either with `workbench.colorTheme` or with `window.autoDetectColorScheme`. in the latter case, four other settings control the theme that is enabled. this commit updates the `syncToIconPack` function to take `autoDetectColorScheme` into account and correctly sync the icon theme when it's enabled.
sgoudham
approved these changes
Jul 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
users can set their active color theme either with
workbench.colorThemeor withwindow.autoDetectColorScheme.in the latter case, four other settings control the theme that is enabled.
this commit updates the
syncToIconPackfunction to takeautoDetectColorSchemeinto account and correctly sync the icon theme when it's enabled.fixes #398 (or rather a secondary issue that was raised there)