-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: deduplicate palette colors #39
Conversation
Thanks for your PR! The original idea was to have the flavour files separately, in case people only needed one/a specific set of flavours. |
Ok, that's indeed an obvious overhead I missed. Not sure if it is even worth solving it like this then. |
Yeah, requiring people to use two files for what's supposed to be the more minimalist usage is pretty counter-intuitive. I'd happily accept changes to the PR generating those SCSS files, or might do it myself. De-duplicating where possible is always welcome. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just marking this as reviewed, see my PR comment.
Okay so a generator that spits out the scss palettes would be cool? I'll edit the PR somewhere this weekend. |
Yeah, if possible similarly to #36, which changed our generator scripts |
Okay, would like the different color formats as well? |
I don't think it's needed since the Sass preprocessor offers the functions to change opacity, darken/lighten, regardless of the color format. If I'm wrongly informed on that, and there would be some benefit, then probably yes. |
This refactor takes care of color hex code duplication between
_catppuccin.scss
and_<flavour>.scss
.Specific flavours get their palette from
_catppuccin.scss
and use this to create their color variables.Feedback is welcome, happy to revisit if required! 🐱