-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial implementation for hnsw #1955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial comments...
src/main/java/io/anserini/search/topicreader/JsonStringVectorTopicReader.java
Show resolved
Hide resolved
src/main/java/io/anserini/index/generator/VectorLuceneDocumentGenerator.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1955 +/- ##
============================================
- Coverage 60.14% 57.60% -2.54%
Complexity 1061 1061
============================================
Files 178 187 +9
Lines 9903 10339 +436
Branches 1371 1422 +51
============================================
Hits 5956 5956
- Misses 3441 3877 +436
Partials 506 506
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for now, but we'll need to circle back to add tests later.
indexed with 25 threads and default HNSW config
indexing time 12:20:00
efS 10, QPS 716, MRR 0.2376
efS 100, QPS 332, MRR 0.3103
efS 1000, QPS 58, MRR 0.3275
indexed with 1 thread and default HNSW config
indexing time 17:26:00
efS 10, QPS 762, MRR 0.2199
efS 100, QPS 331, MRR 0.3060
efS 1000, QPS 62, MRR 0.3266
multi-thread search works well