Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cohere Support #457

Merged
merged 5 commits into from
Jun 8, 2024
Merged

Conversation

TechxGenus
Copy link
Contributor

No description provided.

@casper-hansen
Copy link
Owner

I see this is a draft PR. @TechxGenus have you done any further testing?

@TechxGenus TechxGenus marked this pull request as ready for review April 29, 2024 13:40
@TechxGenus
Copy link
Contributor Author

TechxGenus commented Apr 29, 2024

Hi @casper-hansen , I tested it with transformers, works well.
Marked as draft as missing fusion layer implementation. I don't have enough hardware to write and test it recently. Maybe merge it and wait for a later commit.

@kwonjihun-theori
Copy link
Contributor

@TechxGenus
I was unable to commit to that PR, so I forked your forked branch and submitted a PR.

As mentioned in the PR's description, it seems to have been implemented plausibly but it does not work properly. I want to contribute to this cohere model support project, and I have the hardware necessary to conduct tests.

This is my first attempt at contributing to an open source project, so I might be inexperienced or incorrect in using Git. If there are any mistakes, I would appreciate your pointing them out. @TechxGenus @casper-hansen

@TechxGenus
Copy link
Contributor Author

Hi @casper-hansen , this PR has been tested in both modes and is ready for merging.

@alijawad07
Copy link

@casper-hansen can you please merge this PR by @TechxGenus. I really need this cohere capability :)

@kwonjihun-theori
Copy link
Contributor

hello @casper-hansen, is there any issue with this PR? Could you please let me know if there is a reason for not merging it?

@casper-hansen casper-hansen merged commit 5fa02b5 into casper-hansen:main Jun 8, 2024
@casper-hansen
Copy link
Owner

Sorry for taking so long. I took leave from working on open-source the past month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants