Issue #313: allow checking pending invoices

[Guilospanck]

• Updates deprecated datetime.utcfromtimestamp in the cashu/wallet/cli/cli.py file;
• Adds new options to the invoices CLI command:
  • --only-paid (-op): retrieve only paid invoices;
  • --only-unpaid (-ou): retrieve only unpaid invoices;
  • --pending (-p): retrieve only pending invoices.

Pending invoice was defined as invoices with paid = False and out = False (not sure if this is right).

Closes #313 .

[callebtc]

YES! Welcome and thank you.

[Guilospanck]

Thanks! Noticed that the checks are not passing. Will try to fix it. I only ran the poetry run pytest and thought it was enough.

[Guilospanck]

From what I saw the tests are breaking because of the datetime (the same reason why mypy check is breaking). It was "working on my machine", probably because how it sees the datetime module or something like that.

This new commit should work as mypy is also passing.

[callebtc]

Were you going to add the "mint tokens" part of issue #313 as well? This only displays the unpaid ones, right?

[codecov]

Codecov Report

Attention: Patch coverage is 93.67089% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 68.38%. Comparing base (3feb023) to head (2d8e4d0).
Report is 5 commits behind head on main.

Files	Patch %	Lines
cashu/wallet/cli/cli.py	93.33%	4 Missing ⚠️
cashu/mint/conditions.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
+ Coverage   67.89%   68.38%   +0.49%     
==========================================
  Files          76       76              
  Lines        6815     6852      +37     
==========================================
+ Hits         4627     4686      +59     
+ Misses       2188     2166      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Guilospanck]

Were you going to add the "mint tokens" part of issue #313 as well? This only displays the unpaid ones, right?

Yes, I just need more time to dive into the code and understand where and how to do it

[Guilospanck]

@callebtc added the mint token part

[callebtc]

@callebtc added the mint token part

Awesome PR thank you! I'd like to add one more nit please, could you change the default behavior to not check (remain offline) and replace the --test flag to something like --check / --mint to do the check / mint?

We'd like to keep the client more offline by default, in case the user just wants to see the invoice requests and not check their state for example.

[Guilospanck]

Make sense! Is this it what you meant?

[callebtc]

Thank you, this looks great!

I see a bunch of changes in unrelated files. I'm trying to understand why our IDEs seem to have different formatting preferences but this discrepancy doesn't seem to cause a black error in the ruff formatter. Do you have any idea?

[Guilospanck]

Good question. I'm not sure. I have the Black Formatter extension installed in my vscode, and only these formatters regarding python:

"[python]": {
    "editor.defaultFormatter": "ms-python.black-formatter",
    "editor.codeActionsOnSave": {
      "source.unusedImports": "explicit"
    }
  },

Probably something related to this

[callebtc]

🫡