NUT-00: CBOR-encoded TokenV4 #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcaseria
reviewed
Apr 8, 2024
AngusP
reviewed
Apr 11, 2024
00.md
Outdated
Comment on lines
238
to
242
| When serialized, a TokenV4 looks like this: | ||
|
|
||
| ``` | ||
| cashuBoWF0gaJhbXVodHRwOi8vbG9jYWxob3N0OjMzMzhhcIKkYWlIAIiC2b1wghxhYQJhc3hAMGY5OTJmYmNmZjQ1MGI2YzJmNWNiYWMwMmQ2OWE4ZDUwOGIwOTEyYzEwZTI1NDVlYmEyZGVmNTU0M2FhNDVlMWFjWCECWAksUObH-oRm-Oa1whlFLElCyz5i_r1zyC1etH_Kmc6kYWlIAIiC2b1wghxhYQhhc3hAYTg5NGZjNDljZWYxMmM3MGFjMDhhZmQ2YTRkZTY4ZmQ2M2JiOWJjYmY5MzAyZTc3OTdiZTQ1ZDc2MGNiOGFmY2FjWCEC4rg3LKRNqFEtqV-xqtqX2WypEzSFhDAd7WHdiSQsZ6c= | ||
| ``` |
There was a problem hiding this comment.
Would be nice to give the same token in v3 encoding, as a size comparison and also as a test case
There was a problem hiding this comment.
I'll work on this!
AngusP
approved these changes
Apr 22, 2024
thesimplekid
reviewed
Jun 6, 2024
elnosh
reviewed
Jun 11, 2024
Co-authored-by: elnosh <elnosh@pm.me>
2 tasks
callebtc
changed the title
|
Done ed29eb2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a new TokenV4 binary encoding format using CBOR that reduces token size by around 40%.
It is implemented as a WIP and POC in cashubtc/nutshell#502
Todo: