Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not navigating to the scan-QR #88

Merged
merged 4 commits into from
Jun 23, 2023
Merged

fix: not navigating to the scan-QR #88

merged 4 commits into from
Jun 23, 2023

Conversation

KKA11010
Copy link
Collaborator

The qr screen did not show after pressing the QR icon from the addressbook screen and the settings screen due to the missing nav prop

@KKA11010 KKA11010 added the bug Something isn't working label Jun 23, 2023
@KKA11010 KKA11010 added this to the First Beta Release milestone Jun 23, 2023
@KKA11010 KKA11010 marked this pull request as draft June 23, 2023 20:47
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (38311f6) 24.54% compared to head (d5ec7bc) 24.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   24.54%   24.54%           
=======================================
  Files          85       85           
  Lines        3019     3019           
  Branches      815      815           
=======================================
  Hits          741      741           
  Misses       2214     2214           
  Partials       64       64           
Impacted Files Coverage Δ
src/components/screens/Addressbook/index.tsx 0.00% <ø> (ø)
src/components/screens/Lightning/pageContent.tsx 0.00% <ø> (ø)
src/components/screens/Settings/index.tsx 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

BilligsterUser
BilligsterUser previously approved these changes Jun 23, 2023
@BilligsterUser BilligsterUser requested review from BilligsterUser and removed request for BilligsterUser June 23, 2023 22:05
@KKA11010 KKA11010 marked this pull request as ready for review June 23, 2023 22:13
@BilligsterUser BilligsterUser merged commit 33bb40f into main Jun 23, 2023
3 checks passed
@BilligsterUser BilligsterUser deleted the fix-nav branch June 23, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants