enhancement: show an error message if openLink fails

[SamantaTarun]

Use catch block to show a message that opening the link does not work

https://github.com/cashubtc/eNuts/blob/main/src/util/index.ts#L178

closes: #58

[SamantaTarun]

@KKA11010 where should i put toast?

should i put it everywhere openurl is called?

[KKA11010]

Hello @tarunsamanta2k20

Thanks for the PR! 💪

Yes the Toaster component should be in each screen where this openUrl is called. But I think it will not work if you write the {prompt} hook in the openUrl function.

I just use the prompt hook in the same component where openUrl is needed.

// component where openUrl is called

Component xyz () {

const {prompt, openPromptAutoClose} ...

testFunction(){
  Try {
    OpenUrl...
  } catch (e) {
    OpenPrompt({...})
  }
}

Return <>
  ... component content ...
  <Button onPress={testFunction}>
   ...Btn Text...
  </>

  <Toaster />
</>

Maybe like this? But you can just play around and see if your way works

👍

[SamantaTarun]

@KKA11010 i think it should be like that.

export function OpenUrl(url: string)

[KKA11010]

@KKA11010 i think it should be like that.

export function OpenUrl(url: string)

Yes, it is already.

https://github.com/cashubtc/eNuts/blob/main/src/util/index.ts#L174

Just play around and see if it works the way you are doing it.

[SamantaTarun]

@KKA11010 i think it should be like that.
export function OpenUrl(url: string)

Yes, it is already.

https://github.com/cashubtc/eNuts/blob/main/src/util/index.ts#L174

Just play around and see if it works the way you are doing it.

See 'O' is in lower case. That why it was giving error.

[KKA11010]

@tarunsamanta2k20 the code example that I provided was just pseudo code. Wrote it on my phone and it got autocorrected 😆

You dont have to change how the function name is written. Just use it in the right place

[KKA11010]

Looks great, thank you! Just a few minor changes needed i guess 😍

[KKA11010]

@tarunsamanta2k20 also please have a look at pnpm if you do not use it yet 👍

Yesterday I merged a PR from @BilligsterUser and now we are using pnpm instead of npm

[KKA11010]

LGTM

[codecov-commenter]

Codecov Report

Patch coverage: 13.33% and project coverage change: -0.02 ⚠️

Comparison is base (33bb40f) 24.54% compared to head (db08027) 24.52%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   24.54%   24.52%   -0.02%     
==========================================
  Files          85       85              
  Lines        3019     3029      +10     
  Branches      815      822       +7     
==========================================
+ Hits          741      743       +2     
- Misses       2214     2222       +8     
  Partials       64       64              

Impacted Files	Coverage Δ
src/components/ErrorScreen/ErrorDetails.tsx	0.00% <0.00%> (ø)
src/components/screens/Lightning/modal.tsx	24.74% <0.00%> (-0.79%)	⬇️
src/components/screens/Lightning/payInvoice.tsx	0.00% <0.00%> (ø)
src/util/index.ts	44.33% <0.00%> (ø)
src/components/Balance.tsx	86.66% <50.00%> (-5.00%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.