-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: display 'add a new mint' modal when keyboard is open #64
Conversation
andrew-weber
commented
Jun 16, 2023
•
edited
Loading
edited
whitespace 😠 |
Thanks a lot for the PR! 👍 Its impossible to see what you have done tho so could you please close this and open a new one? I guess your changes will be readable if you run the linter before creating a PR. |
Related to #8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please format the file accordingly to the lint options. There are still too many diffs that are useless and don't belong in the git history.
Regarding the linebreaks, I don't think that removing the rule from the .eslintrc is a good approach. We want to keep a consistent format across the project.
I guess you should be able to configure your IDE to use CRLF for this repository. What do you think @BilligsterUser ?
LGTM. What about you, @BilligsterUser? |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
- Coverage 20.51% 20.47% -0.04%
==========================================
Files 86 86
Lines 3008 3013 +5
Branches 806 811 +5
==========================================
Hits 617 617
- Misses 2330 2335 +5
Partials 61 61
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍