Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display 'add a new mint' modal when keyboard is open #64

Merged
merged 5 commits into from
Jun 17, 2023
Merged

fix: display 'add a new mint' modal when keyboard is open #64

merged 5 commits into from
Jun 17, 2023

Conversation

andrew-weber
Copy link
Collaborator

@andrew-weber andrew-weber commented Jun 16, 2023

alt text

@andrew-weber
Copy link
Collaborator Author

whitespace 😠

@KKA11010
Copy link
Collaborator

Thanks a lot for the PR! 👍 Its impossible to see what you have done tho so could you please close this and open a new one? I guess your changes will be readable if you run the linter before creating a PR.

@KKA11010
Copy link
Collaborator

Related to #8

Copy link
Collaborator

@KKA11010 KKA11010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format the file accordingly to the lint options. There are still too many diffs that are useless and don't belong in the git history.

Regarding the linebreaks, I don't think that removing the rule from the .eslintrc is a good approach. We want to keep a consistent format across the project.

I guess you should be able to configure your IDE to use CRLF for this repository. What do you think @BilligsterUser ?

@KKA11010
Copy link
Collaborator

LGTM.

What about you, @BilligsterUser?

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (6ad04a9) 20.51% compared to head (7a78324) 20.47%.

❗ Current head 7a78324 differs from pull request most recent head aaaadbd. Consider uploading reports for the commit aaaadbd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   20.51%   20.47%   -0.04%     
==========================================
  Files          86       86              
  Lines        3008     3013       +5     
  Branches      806      811       +5     
==========================================
  Hits          617      617              
- Misses       2330     2335       +5     
  Partials       61       61              
Impacted Files Coverage Δ
src/components/modal/index.tsx 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@BilligsterUser BilligsterUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BilligsterUser BilligsterUser merged commit 16bc72d into cashubtc:main Jun 17, 2023
3 checks passed
@andrew-weber andrew-weber deleted the modal-keyboard branch June 18, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working IOS IOS related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants