Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add jscpd & add @consts path alias #36

Merged
merged 6 commits into from
Jun 9, 2023
Merged

add jscpd & add @consts path alias #36

merged 6 commits into from
Jun 9, 2023

Conversation

BilligsterUser
Copy link
Contributor

No description provided.

@BilligsterUser BilligsterUser added duplicate This issue or pull request already exists enhancement New feature or request dependencies Pull requests that update a dependency file labels Jun 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2023 •
edited
Loading

Codecov Report

Patch coverage: 37.50% and project coverage change: -0.05 ⚠️

Comparison is base (aeddf21) 47.90% compared to head (ac89d49) 47.85%.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev      #36      +/-   ##
==========================================
- Coverage   47.90%   47.85%   -0.05%     
==========================================
  Files          25       25              
  Lines        1027     1028       +1     
  Branches      234      233       -1     
==========================================
  Hits          492      492              
  Misses        469      469              
- Partials       66       67       +1
Impacted Files Coverage Δ
src/logger/reactotron/index.ts 100.00% <ø> (ø)
src/logger/reactotron/reactotronClient.ts 100.00% <ø> (ø)
src/logger/reactotron/reactotronConfig.ts 100.00% <ø> (ø)
src/logger/reactotron/reactotronFake.ts 100.00% <ø> (ø)
src/util/crashReporting.ts 0.00% <0.00%> (ø)
src/logger/reactotron/reactotron.ts 50.00% <60.00%> (ø)
src/logger/index.ts 75.00% <75.00%> (-2.28%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

KKA11010
KKA11010 approved these changes Jun 9, 2023
View reviewed changes
Copy link
Collaborator

@KKA11010 KKA11010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👑

@KKA11010
Copy link
Collaborator

KKA11010 commented Jun 9, 2023

You are making the app so much more valuable 🤜🤛

BilligsterUser
BilligsterUser commented Jun 9, 2023
View reviewed changes
src/consts/env.ts Outdated Show resolved Hide resolved
@KKA11010 KKA11010 marked this pull request as draft June 9, 2023 15:09
@BilligsterUser BilligsterUser marked this pull request as ready for review June 9, 2023 15:33
@BilligsterUser BilligsterUser added this to the First Beta Release milestone Jun 9, 2023
@KKA11010 KKA11010 merged commit 4a4224c into cashubtc:dev Jun 9, 2023
@BilligsterUser BilligsterUser deleted the add-jscpd-&-add-@consts-path-alias branch June 9, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KKA11010 KKA11010 KKA11010 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Milestone
First Beta Release
Development

Successfully merging this pull request may close these issues.
3 participants
@BilligsterUser @codecov-commenter @KKA11010