Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Lnurl-Pay through copy/paste and QR code scan #323

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

starbackr-dev
Copy link
Collaborator

@starbackr-dev starbackr-dev commented Mar 22, 2024

[x] Added bech32-encoded lnurl utils file
[x] Detect encoded lnurl in QR code
[x] No new package added other than bech32
[x] Detect lnurl in input field
[x] Handle decoded lnurl-pay, lightning address
[x] use camera to scan and decode lnurl-pay and lightning address
[x] No Update to UI

See #248

[x] Added bech32-encoded lnurl utils file
[x] Detect encoded lnurl in QR code
[ ] No new package added other than bech32
[ ] Detect lnurl in input field
[ ] Handle decoded lnurl-pay, lightning address
[ ] use camera to scan and decode lnurl-pay and lightning address
[ ] Update UI
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 18.66667% with 61 lines in your changes are missing coverage. Please review.

Project coverage is 13.36%. Comparing base (6a7deb8) to head (79277b2).

Files Patch % Lines
src/util/index.ts 22.58% 35 Missing and 13 partials ⚠️
src/screens/QRScan/index.tsx 0.00% 9 Missing ⚠️
src/screens/Payment/Send/Inputfield.tsx 0.00% 2 Missing ⚠️
src/screens/Payment/Processing.tsx 0.00% 1 Missing ⚠️
src/screens/Payment/Send/CoinSelection.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
+ Coverage   13.29%   13.36%   +0.07%     
==========================================
  Files         164      164              
  Lines        6153     6209      +56     
  Branches     1687     1705      +18     
==========================================
+ Hits          818      830      +12     
- Misses       5188     5220      +32     
- Partials      147      159      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@KKA11010 KKA11010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the support! Will carry on the remaining work

@KKA11010 KKA11010 merged commit a6fffdd into cashubtc:main Mar 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants