Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the cashu token QR #32

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Update the cashu token QR #32

merged 3 commits into from
Jun 9, 2023

Conversation

BilligsterUser
Copy link
Contributor

closes #26

@BilligsterUser BilligsterUser added the enhancement New feature or request label Jun 9, 2023
@BilligsterUser BilligsterUser linked an issue Jun 9, 2023 that may be closed by this pull request
Update the cashu token QR #26
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2023 •
edited

Codecov Report

Patch coverage has no change and project coverage change: -0.15 ⚠️

Comparison is base (0cfef2e) 48.37% compared to head (e8cfceb) 48.23%.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev      #32      +/-   ##
==========================================
- Coverage   48.37%   48.23%   -0.15%     
==========================================
  Files          25       25              
  Lines        1017     1020       +3     
  Branches      226      228       +2     
==========================================
  Hits          492      492              
- Misses        461      463       +2     
- Partials       64       65       +1
Impacted Files Coverage Δ
src/wallet/index.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

KKA11010
KKA11010 approved these changes Jun 9, 2023
View reviewed changes
Copy link
Collaborator

@KKA11010 KKA11010 left a comment •
edited by BilligsterUser

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but there is one more thing to change before closing this issue.

  • claiming the token after scanning (Maybe needs to check if the scanned value includes the cashu prefix or not)

@BilligsterUser
Copy link
Contributor Author

BilligsterUser commented Jun 9, 2023 •
edited

eNuts/src/util/index.ts

Line 113 in 0cfef2e

export function isCashuToken(token: string) {

@KKA11010 KKA11010 added this to the First Beta Release milestone Jun 9, 2023
@BilligsterUser
Copy link
Contributor Author

a6a86e5

KKA11010
KKA11010 approved these changes Jun 9, 2023
View reviewed changes
Copy link
Collaborator

@KKA11010 KKA11010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥜

@KKA11010 KKA11010 merged commit 96dfe5f into cashubtc:dev Jun 9, 2023
3 checks passed
@BilligsterUser BilligsterUser deleted the Update-the-cashu-token-QR branch June 9, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KKA11010 KKA11010 KKA11010 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
First Beta Release
Development

Successfully merging this pull request may close these issues.

Update the cashu token QR
3 participants
@BilligsterUser @codecov-commenter @KKA11010