Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show custom mint names in pickers #24

Merged
merged 7 commits into from
Jun 8, 2023
Merged

Show custom mint names in pickers #24

merged 7 commits into from
Jun 8, 2023

Conversation

KKA11010
Copy link
Collaborator

@KKA11010 KKA11010 commented Jun 7, 2023

This PR has a lot of changes and I was not prepaired accordingly. The changes should have been done in smaller steps (Screen by screen) so the review could have been simplier.

  • Changed the type of the the mint states and the selected mint states, which affected the navigation parameters and a lot of components using the states passed on to them.
  • Update the Pickup options to show the custom name if one is provided.

@KKA11010 KKA11010 added the enhancement New feature or request label Jun 7, 2023
src/components/pages/Lightning/index.tsx Outdated Show resolved Hide resolved
src/components/pages/Lightning/mintPanel.tsx Outdated Show resolved Hide resolved
src/components/pages/Lightning/mintPanel.tsx Outdated Show resolved Hide resolved
src/components/pages/Lightning/index.tsx Outdated Show resolved Hide resolved
src/components/pages/Lightning/scannedQR.tsx Show resolved Hide resolved
src/components/pages/Mints/IntermintSwap.tsx Outdated Show resolved Hide resolved
src/util/index.ts Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (69c5921) 44.51% compared to head (4dfdd7e) 44.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #24      +/-   ##
==========================================
- Coverage   44.51%   44.46%   -0.05%     
==========================================
  Files          19       19              
  Lines         966      967       +1     
  Branches      209      209              
==========================================
  Hits          430      430              
- Misses        473      474       +1     
  Partials       63       63              
Impacted Files Coverage Δ
src/storage/store/mintStore.ts 0.00% <0.00%> (ø)
src/util/index.ts 31.68% <0.00%> (-0.32%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@BilligsterUser BilligsterUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BilligsterUser BilligsterUser merged commit 1490bb0 into dev Jun 8, 2023
3 checks passed
@BilligsterUser BilligsterUser deleted the custom-mint-name branch June 8, 2023 09:26
@BilligsterUser BilligsterUser restored the custom-mint-name branch June 8, 2023 09:27
@BilligsterUser BilligsterUser deleted the custom-mint-name branch June 8, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants