Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add openLinkInBrowser helper && update jest setup #22

Merged
merged 5 commits into from
Jun 7, 2023
Merged

add openLinkInBrowser helper && update jest setup #22

merged 5 commits into from
Jun 7, 2023

Conversation

BilligsterUser
Copy link
Contributor

@BilligsterUser BilligsterUser commented Jun 6, 2023

/**
   * Try to open the given url with any of the installed apps.
   * You can use other URLs, like a location (e.g. "geo:37.484847,-122.148386"), a contact, or any other URL that can be opened with the installed apps.
   * NOTE: This method will fail if the system doesn't know how to open the specified URL. If you're passing in a non-http(s) URL, it's best to check {@code canOpenURL} first.
   * NOTE: For web URLs, the protocol ("http://", "https://") must be set accordingly!
   */
  openURL(url: string): Promise<any>;

  /**
   * Determine whether or not an installed app can handle a given URL.
   * NOTE: For web URLs, the protocol ("http://", "https://") must be set accordingly!
   * NOTE: As of iOS 9, your app needs to provide the LSApplicationQueriesSchemes key inside Info.plist.
   * @param URL the URL to open
   */
  canOpenURL(url: string): Promise<boolean>;

@BilligsterUser BilligsterUser added enhancement New feature or request test Test related labels Jun 6, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.33 🎉

Comparison is base (c46ca8c) 44.22% compared to head (bf6a989) 44.55%.

❗ Current head bf6a989 differs from pull request most recent head 34655d4. Consider uploading reports for the commit 34655d4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #22      +/-   ##
==========================================
+ Coverage   44.22%   44.55%   +0.33%     
==========================================
  Files          20       19       -1     
  Lines         970      965       -5     
  Branches      210      208       -2     
==========================================
+ Hits          429      430       +1     
+ Misses        479      473       -6     
  Partials       62       62              
Impacted Files Coverage Δ
src/util/index.ts 32.32% <50.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BilligsterUser BilligsterUser added the CI CI related issue label Jun 6, 2023
Copy link
Collaborator

@KKA11010 KKA11010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️⚡️⚡️

@KKA11010 KKA11010 merged commit 69c5921 into cashubtc:dev Jun 7, 2023
3 checks passed
@BilligsterUser BilligsterUser deleted the add-openLinkInBrowser-helper-&&-update-jest-setup branch June 7, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI related issue enhancement New feature or request test Test related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants