Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong swipe back after token creation #194

Closed
dtonon opened this issue Sep 10, 2023 · 7 comments
Closed

Wrong swipe back after token creation #194

dtonon opened this issue Sep 10, 2023 · 7 comments
Assignees
Labels
Android Android related issues bug Something isn't working completed 🌟 Changes are already available and have to be merged IOS IOS related issues

Comments

@dtonon
Copy link

dtonon commented Sep 10, 2023

Describe the bug
After creating a token, if the user in the last view swipes back, he is brought back to the "Cashu is beeing created" view.

To Reproduce
Steps to reproduce the behavior:

  1. Use Send and create a token
  2. In the last view swipe back (right to left from the right edge)

Expected behavior
The user should be brought to the home.

Desktop (please complete the following information):

  • OS: Android
  • Version apk 0.3.0
@KKA11010 KKA11010 self-assigned this Sep 10, 2023
@KKA11010 KKA11010 added bug Something isn't working IOS IOS related issues labels Sep 10, 2023
@dtonon
Copy link
Author

dtonon commented Sep 11, 2023

@KKA11010 pay attention to the fact that the issue has been labeled "IOS" while I tested it on Android.

@KKA11010
Copy link
Collaborator

Oh ok thank you for the hint 🥇

@KKA11010 KKA11010 added the Android Android related issues label Sep 11, 2023
@swedishfrenchpress
Copy link
Collaborator

I was able to reproduce this on Android but not on iOS. Android has that unique "swipe right to left" to go back.
Screenshot_20230913-231410
Screenshot_20230913-231414

KKA11010 added a commit that referenced this issue Sep 14, 2023
* disable gesture nav on specific screens (ios)

* disable gesture nav on dashboard (ios)

* disable gesture nav on auth screen (ios)

* add 'beforeRemove' nav listener, see #194

* update
@swedishfrenchpress
Copy link
Collaborator

Looks like this has been fixed in the latest version @KKA11010
https://github.com/cashubtc/eNuts/assets/78821053/c747529d-aec9-4a41-ac95-ead373ba8ab4

@KKA11010
Copy link
Collaborator

Looks like this has been fixed in the latest version @KKA11010 https://github.com/cashubtc/eNuts/assets/78821053/c747529d-aec9-4a41-ac95-ead373ba8ab4

Ok, Thank you for testing out 🥇

@swedishfrenchpress
Copy link
Collaborator

Tested in following screens too. It worked on the following three:

  • new cashu token
  • success screen
  • processing screen (the loading screen right before success or new cashu token)

However, I wasn't able to test on the dashboard.

  • dashboard (was going back to PIN screen)
    I think because I'm running eNuts on the Expo Go app i can't fully test this. When I swipe back it takes to me the ExpoGo app screen.

@KKA11010
Copy link
Collaborator

Tested in following screens too. It worked on the following three:

* new cashu token

* success screen

* processing screen (the loading screen right before success or new cashu token)

However, I wasn't able to test on the dashboard.

* dashboard (was going back to PIN screen)
  I think because I'm running eNuts on the Expo Go app i can't fully test this. When I swipe back it takes to me the ExpoGo app screen.

It is the correct behavior, it does not take you from dashboard back to the pin screen but out of the app and that is ok i guess 👍

@KKA11010 KKA11010 added the completed 🌟 Changes are already available and have to be merged label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Android related issues bug Something isn't working completed 🌟 Changes are already available and have to be merged IOS IOS related issues
Projects
None yet
Development

No branches or pull requests

3 participants