fix: normalize GitHub URLs ending in .git to not ending in .git

[kristof-mattei]

Closes #1801, see #1803 for a more generic version.

Here I can add the test as the GhApiClient is never invoked.

[NobodyXu]

Thank you!

Based on https://stackoverflow.com/questions/11068576/why-do-some-repository-urls-end-in-git-while-others-dont , I recommend to try url with stripped .git first, and then fallback to not stripping it, to keep the same behavior with git.

[NobodyXu]

Pinging @kristof-mattei just in case you forgot this PR

[kristof-mattei]

@NobodyXu These calls here (in the code I modified) never fail. It is only later on when trying to fetch the releases that the API doesn't respond with releases for repos ending in .git.

Now, if I understand correctly, you'd prefer that I revert this code, and then change the code around where the API for the releases itself gets called. First with the original URL, and if it fails AND ends in .git, try again with it trimmed?

[NobodyXu]

Now, if I understand correctly, you'd prefer that I revert this code, and then change the code around where the API for the releases itself gets called. First with the original URL, and if it fails AND ends in .git, try again with it trimmed?

No, what I mean is to extract the repository detection logic here into a function, the call it twice:

• First without the .git suffix
• the fallback to with the suffix, if it has the suffix

I'd want the repository detection logic to only happen in get_repo_info, not when fetching artifacts.

[NobodyXu]

These calls here (in the code I modified) never fail.

cc @kristof-mattei there's a GhApiClient::get_repo_info call which we uses to check if the repository exists:

cargo-binstall/crates/binstalk-fetchers/src/lib.rs

Line 212 in 928e28a

match client.get_repo_info(&gh_repo).await {

In case where user does not provide a github token, we could use Client::get_redirected_final_url

cargo-binstall/crates/binstalk-fetchers/src/lib.rs

Line 199 in 928e28a

repo = client

I recommend you to start by doing something similar to GhRepo::try_extract_from_url to parse the git repository url.

If it cannot be parsed, then it is not a repo link (maybe a link to a specific dir within the repository) so it doesn't need stripping .git.

If it parses successfully then you can try strip the .git, if successful, then

Use either get_repo_info for github repo or get_redirected_final_url and return it if it can be accessed.

Otherwise just fallback to regular path.

[NobodyXu]

Thank you for this PR!

I happen to have some time so I took over the work and complete it.