Revert to 'ld' linker name for darwin targets #1781
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodyXu
requested changes
Jun 18, 2024
| @@ -9,8 +9,8 @@ rustflags = ["-C", "link-arg=-fuse-ld=lld"] | |||
| rustflags = ["-C", "link-arg=-fuse-ld=lld"] | |||
|
|
|||
| [target.x86_64-apple-darwin] | |||
| rustflags = ["-C", "link-arg=-fuse-ld=lld"] | |||
There was a problem hiding this comment.
I should have add the flags in justfile instead.
can you instead remove these target overrides?
Merged
|
hello @timsutton I've merged in #1782 which removed |
|
Sounds good, thanks for the quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 I help maintain homebrew-core, and noticed this was no longer building successfully on darwin:
I reverted it to the standard
ldlinker that ships with Apple's CLI tools / Xcode. Hope this helps!