Use binary name when searching for artifacts #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is a single binary declared in the manifest and it differs from the package name, add it to the list of handles used for pre-built artifact fetching.
NobodyXu
requested changes
Jun 13, 2024
NobodyXu
requested changes
Jun 13, 2024
NobodyXu
requested changes
Jun 13, 2024
NobodyXu
requested changes
Jun 14, 2024
Technically it should also check if gh-crate-meta resolver is enabled, but it is unlikely for it to be disabled and overallocating for extra n-target should be fine, it is an improvement over doubling the space allocated if the binary_name is Some.
NobodyXu
requested changes
Jun 14, 2024
|
Thank you for your quick review and overall maintenance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a single binary declared in the manifest and it differs from the package name, add it to the list of handles used for pre-built artifact fetching.
Fixes #988