-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WARN Failed to retrieve token from `gh auth token' on every install and it slows down automated installations. #1733
Comments
You can disable it using |
i feel like we could silence this warning unless it |
* Log the gh-auth token retrieval failure on debug level Fixed #1733 * Make gh_token::get an async function * Improve returned err msg in gh_token::get * Update use of gh_token::get() in entry.rs * Fix typos * Fix unclosed () * Fix unclosed () * Fix gh_token.rs * Fix entry.rs * Fix fmt in entry.rs * Fix fmt in gh_token.rs * Fix fmt in gh_token.rs * Fix fmt in gh_token.rs * Fix fmt in entry.rs
@ryankurte thank you for acting on this in this quick manner. But only silencing it won't fix the underlying issue. Because in my case for example it stops ansible from executing until it times out. |
Oh you have gh installed using ansible and it is quite slow? I never encountered such environment, I've already converted the gu-auth-token execution to be async |
@cocoonkid You can disable it using --no-discover-github-to out of curiosity, how long does it take for for |
What about the case when some other binary executes it? |
I can:
BTW if you explicitly provide a github token via env var BTW how long does it take for |
For #1733 Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@alex35mil @cocoonkid Opened #1763 for an env var to disable github token scraping. |
* Add env var BINSTALL_NO_DISCOVER_GITHUB_TOKEN For #1733 Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * Fix fmt Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> * Fix fmt Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com> --------- Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Released cargo-binstall 1.7.0 |
Apology for the late reply: I installed gh on the hosts as well but this did not help. (which is kinda weird?) The timeout in my case happened around the 30sec mark. Will try out the ENV var soon! thanks so much for the quick fix! |
Just confirming: the env variable solved the isssue as expected. Many many thanks! |
I think it's because of the order in |
How can I disable this ? the systems I am using cargo-binstall on do not even have gh installed at all.
Thanks for looking into this.
The text was updated successfully, but these errors were encountered: