Skip to content

Commit

Permalink
Merge pull request #1580 from cardstack/remove-composable-helpers
Browse files Browse the repository at this point in the history
Remove ember-composable-helpers
  • Loading branch information
ef4 committed Sep 17, 2024
2 parents d82ca22 + 2fb054d commit 2cff8b4
Show file tree
Hide file tree
Showing 10 changed files with 7 additions and 67 deletions.
2 changes: 0 additions & 2 deletions packages/boxel-motion/test-app/types/global.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import '@cardstack/boxel-motion/glint';
import type BoxelMotionRegistry from '@cardstack/boxel-motion/template-registry';

import { HelperLike } from '@glint/template';
import PickHelper from 'ember-composable-helpers/helpers/pick';
import AndHelper from 'ember-truth-helpers/helpers/and';
import EqHelper from 'ember-truth-helpers/helpers/eq';
import NotHelper from 'ember-truth-helpers/helpers/not';
Expand All @@ -15,7 +14,6 @@ declare module '@glint/environment-ember-loose/registry' {
and: typeof AndHelper;
or: typeof OrHelper;
not: typeof NotHelper;
pick: typeof PickHelper;
'page-title': HelperLike<{
Args: { Positional: [title: string] };
Return: void;
Expand Down
1 change: 0 additions & 1 deletion packages/boxel-ui/addon/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
"classnames": "^2.3.2",
"dayjs": "^1.11.7",
"ember-basic-dropdown": "^8.0.0",
"ember-composable-helpers": "^5.0.0",
"ember-css-url": "^1.0.0",
"ember-focus-trap": "^1.0.1",
"ember-freestyle": "^0.20.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/boxel-ui/addon/src/components/menu/index.gts
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ import { fn } from '@ember/helper';
import { on } from '@ember/modifier';
import { action } from '@ember/object';
import Component from '@glimmer/component';
import compact from 'ember-composable-helpers/helpers/compact';
import cssUrl from 'ember-css-url';
import { Link } from 'ember-link';

import cn from '../../helpers/cn.ts';
import compact from '../../helpers/compact.ts';
import type { MenuDivider } from '../../helpers/menu-divider.ts';
import type { MenuItem } from '../../helpers/menu-item.ts';
import { eq } from '../../helpers/truth-helpers.ts';
Expand Down
2 changes: 2 additions & 0 deletions packages/boxel-ui/addon/src/helpers.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import cn from './helpers/cn.ts';
import compact from './helpers/compact.ts';
import { getContrastColor } from './helpers/contrast-color.ts';
import cssVar from './helpers/css-var.ts';
import dayjsFormat from './helpers/dayjs-format.ts';
Expand All @@ -15,6 +16,7 @@ export {
and,
bool,
cn,
compact,
cssVar,
dayjsFormat,
element,
Expand Down
3 changes: 3 additions & 0 deletions packages/boxel-ui/addon/src/helpers/compact.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export default function compact<T>(value: T[]): NonNullable<T>[] {
return value.filter((item) => Boolean(item)) as NonNullable<T>[];
}

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ import { on } from '@ember/modifier';
import { action } from '@ember/object';
import Component from '@glimmer/component';

import compact from 'ember-composable-helpers/helpers/compact';

import { cn, eq } from '@cardstack/boxel-ui/helpers';
import { cn, eq, compact } from '@cardstack/boxel-ui/helpers';

import { DiagonalArrowLeftUp } from '@cardstack/boxel-ui/icons';

Expand Down
1 change: 0 additions & 1 deletion packages/host/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@
"ember-cli-terser": "^4.0.2",
"ember-cli-typescript-blueprints": "^3.0.0",
"ember-click-outside": "^6.0.1",
"ember-composable-helpers": "^5.0.0",
"ember-concurrency": "^3.1.1",
"ember-css-url": "^1.0.0",
"ember-elsewhere": "^2.0.0",
Expand Down
11 changes: 0 additions & 11 deletions packages/host/types/ember-composable-helpers/index.d.ts

This file was deleted.

37 changes: 0 additions & 37 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 2cff8b4

Please sign in to comment.