Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): use plex in manager ui even when not installed #17308

Conversation

tay1orjones
Copy link
Member

Something I noticed in #16910 - on machines that do not have Plex installed, the storybook uses a system default font.

Changelog

Changed

  • Update storybook's manager-head.html to load plex from the CDN into the Manager portion of storybook (sidebar nav, controls pane, etc.)

Testing / Reviewing

  • Open the deploy preview on a machine with plex installed
    • inspect in the firefox dev tools 'fonts' pane, the locally installed version of plex should be on the page in addition to the one(s) loaded from the deploy preview itself.
  • Open the deploy preview on a machine without plex installed
    • inspect in the firefox dev tools ... you should see plex being loaded from s81c.com/...
    • The storybook Manager ui should be rendered with plex
Windows w/out local Plex (old) Windows w/out local Plex (this PR) Mac w/ local Plex (prod)

@tay1orjones tay1orjones requested a review from a team as a code owner August 30, 2024 18:53
@tay1orjones tay1orjones self-assigned this Aug 30, 2024
@tay1orjones tay1orjones added role: dev 🤖 type: infrastructure 🤖 Issues relating to devops, tech debt, etc. labels Aug 30, 2024
Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0532e00
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66d789c9fabff20008e900aa
😎 Deploy Preview https://deploy-preview-17308--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0532e00
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66d789c94ca5050008848ff6
😎 Deploy Preview https://deploy-preview-17308--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

image image

@tay1orjones tay1orjones added this pull request to the merge queue Sep 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 3, 2024
@tay1orjones tay1orjones added this pull request to the merge queue Sep 4, 2024
Merged via the queue into carbon-design-system:main with commit 6dd3d88 Sep 4, 2024
23 checks passed
@tay1orjones tay1orjones deleted the enhance-plex-support-storybook branch September 4, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants