fix(16781): fixes Tab focus issue on accordion #17120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kennylam
reviewed
Aug 8, 2024
Merged
via the queue into
carbon-design-system:main
with commit Aug 12, 2024
9b737e8
22 checks passed
|
Hey there! v11.64.0 was just released that references this issue/PR. |
This was referenced Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16781
This PR prevents focus on reach onto collapsed according item, this usually happened when accordionItem was intractable element
Changelog
New
Added
hidden={!isOpen}attribute to wrapper divChanged
Snapshot updated
Testing / Reviewing
Verify that when navigating accordion through Keyboard Tab navigation the focus does not reach on collapsed according item