Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using a newer version of Gridish for experimental grid. #738

Closed
j1mie opened this issue Apr 30, 2018 · 3 comments
Closed

Using a newer version of Gridish for experimental grid. #738

j1mie opened this issue Apr 30, 2018 · 3 comments
Labels
status: won't fix ❌

Comments

@j1mie
Copy link
Contributor

j1mie commented Apr 30, 2018

Some class names have been added, removed or changed in CSS Gridish, from when you guys added it behind an experimental flag.

I'd be happy to open a PR with a more recent version of Gridish, using your values. Would you guys consider generating the grid as part of your build process, or would that be a little overkill?
@joshblack
Copy link
Contributor

@j1mie definitely would want to generate it as part of our build process! The only thing is that the project generates more files than we need, would be helpful to support: IBM/css-gridish#20

@j1mie
Copy link
Contributor Author

j1mie commented May 1, 2018 •
edited
Loading

@joshblack Was thinking this too - although generated markdown and sketch files look like they'd be excluded from being published to NPM with your current file settings.

Our team is hoping to use CSS Gridish going forward so I could help with IBM/css-gridish#20

@shinytoyrobots
Copy link
Contributor

Closing as this is really a question / enhancement within the gridish repo.

joshblack pushed a commit to joshblack/carbon that referenced this issue May 2, 2019
@rezak-otmani @joshblack
fix ComposedModal does not close when open, resolves carbon-design-sy…
61376a0 
…stem#738 (carbon-design-system#747)

* fix(ComposedModal): fix ComposedModal does not close when open, resolves carbon-design-system#738

* fix(ComposedModal): fix ComposedModal does not close when open, resolves carbon-design-system#607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: won't fix ❌
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shinytoyrobots @joshblack @j1mie