Add Puppeteer snapshot testing #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good! Mind opening up an issue about the preset silently not working when in |
|
Will do! |
|
So, this is failing on Travis. Hard to tell why. Need sone way to get access to the diff png. |
|
Haven't yet figured out how to get this working on Travis. In the mean time I've disabled it on Travis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an example, here's a fake bug I introduced locally to test the snapshots:
Pretty subtle! Using single colons instead of double colons in this CSS selector is invalid. This causes the default skin to show through only when loading a custom skin, since the custom skin's dynamically generated CSS is not correct. (Default skin CSS is pre-generated).
Error message
Note with iTerm, I can cmd+click on the image path to open the image diff in Preview.
Diff image generated by jest-image-snapshot
On the left is the checked in version, on the right is the version generated in my test. In the middle is an image which highlights the change.
If you open the image full size, you can see that the slider is slightly different.
Before
After
Note: Tests are failing due to Yarn outage https://status.yarnpkg.com/
cc @aaronabramov and @SimenB