Restore the ARM register naming from v4. #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v5 the register naming for ARM registers changed. This was not a documented behaviour, and may not be desireable. This change makes the register names in v5 the same as they were in v4 - that is that when NOREGNAME is used, R13 and R14 are known as `sp` and `lr`. They had been changed to `r13` and `r14`. See capstone-engine#2078 for more details.
XVilka
approved these changes
Jul 22, 2023
|
Thanks. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v5 the register naming for ARM registers changed. This was not a documented behaviour, and may not be desireable.
This change makes the register names in v5 the same as they were in v4 - that is that when NOREGNAME is used, R13 and R14 are known as
spandlr. They had been changed tor13andr14.See #2078 for more details.