[ARM] Fix VFP feature check #2090

Rot127 · 2023-07-18T11:18:49Z

ARM VFP instructions could not be disassembled if arch != armv8. This happens because of a faulty feature check. The check assumes VFP is v8 only.

This is not the case as can be checked with LLVM:

echo "0x04,0x0b,0xb7,0xee,0x10,0xfa,0xf1,0xee,0x02,0x0b,0x31,0xee,0x42,0x0b,0x31,0xee,0xc8,0x1b,0xb0,0xee" | llvm-mc-16 --triple=armv7 --mattr=+vfp3 --disassemble
	.text
	vmov.f64	d0, #1.250000e+00
	vmrs	APSR_nzcv, fpscr
	vadd.f64	d0, d1, d2
	vsub.f64	d0, d1, d2
	vabs.f64	d1, d8

VFP instructions could only be disassembled if armv8 was set as arch. This is because the predicate fails due to this feature check. This is incorrect as also armv7 can have VFP support.

aquynh · 2023-07-18T15:57:41Z

merged, thanks!

Fix VFP feature check.

4dd5aec

VFP instructions could only be disassembled if armv8 was set as arch. This is because the predicate fails due to this feature check. This is incorrect as also armv7 can have VFP support.

Rot127 changed the base branch from next to v5 July 18, 2023 11:19

Rot127 mentioned this pull request Jul 18, 2023

Add asm test for arm32 il lifter rizinorg/rizin#3662

Merged

5 tasks

XVilka mentioned this pull request Jul 18, 2023

5.0.x release suggestions #2081

Closed

24 tasks

XVilka approved these changes Jul 18, 2023

View reviewed changes

aquynh merged commit 270d16e into capstone-engine:v5 Jul 18, 2023
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ARM] Fix VFP feature check #2090

[ARM] Fix VFP feature check #2090

Rot127 commented Jul 18, 2023

aquynh commented Jul 18, 2023

[ARM] Fix VFP feature check #2090

[ARM] Fix VFP feature check #2090

Conversation

Rot127 commented Jul 18, 2023

aquynh commented Jul 18, 2023